Rework server list #1442
Open
Rework server list #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids calls of reloadData for simple connection status updates.
wutschel
force-pushed
the
rework_serverlist
branch
from
57133e0 to
aa793b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies two main changes:
Introduce
updateServerCellStatusThe new method
updateServerCellStatusupdates the server list cell's connection status icon only. This allows to reduce the amount ofreleadDatacalls, which was before used to do this.Introduce
noFoundLabelThe UILabel
noFoundLabelis used to signal an empty server list. It is faded in/out depending on the state of the list. This allows to remove the former solution which based on a dummy cell.Other smaller changer were related to coding styles and minor refactoring.
Summary for release notes
Improvement: Using UILabel to signal "No saved hosts found" instead of creating a dummy cell
Improvement: Avoid calling reloadData by only updating connection status icon when needed
Maintenance: Coding styles and minor refactoring